Citron/Emulator

fix/network-zstd-packet-handling #77

Merged

Zephyron merged 4 commits from fix/network-zstd-packet-handling into main

2025-12-26 06:55:02 +00:00

Zephyron commented

2025-12-26 06:54:55 +00:00

Owner

No description provided.

Zephyron added 4 commits

2025-12-26 06:54:56 +00:00

fix(network): improve ZSTD compression/decompression error handling 38d4152021

- Add error checking after decompression to drop corrupted packets
- Add error checking after compression to prevent sending empty packets
- Allow ZSTD_CONTENTSIZE_UNKNOWN and use streaming decompression
- Only reject ZSTD_CONTENTSIZE_ERROR as a fatal error

Fixes network connectivity issues where corrupted/empty packets were
being processed, breaking the network protocol.

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(fatal): handle unknown error module 359 gracefully 499b3c1a59

Handle error 2359-2618 (module 359, description 2618) gracefully
by logging a warning instead of crashing, similar to module 56.
This allows games like SSBU to continue execution when encountering
this error code.

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(ldn): improve packet validation and debug logging 14c97aebb7

- Add size validation before memcpy for Connect/Disconnect packets
- Allow empty data for Scan packets (Type 0) which have no payload
- Add debug logging for ScanResp packets including BSSID and results
- Fix MacAddress indexing to use .raw[] instead of [] operator

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(network): revert to legacy packet format for emulator compatibility aad942cf25

Remove the 'reliable' boolean field from LDNPacket and ProxyPacket
structs and all associated serialization/deserialization logic.
All packets now use reliable delivery by default via ENet layer,
matching the legacy format for full backward compatibility.

Signed-off-by: Zephyron <zephyron@citron-emu.org>

Zephyron merged commit ba7141c8ee into main

2025-12-26 06:55:02 +00:00

Zephyron deleted branch fix/network-zstd-packet-handling

2025-12-26 06:55:02 +00:00

Zephyron referenced this pull request from a commit

2025-12-26 06:55:03 +00:00

Merge pull request 'fix/network-zstd-packet-handling' (#77) from fix/network-zstd-packet-handling into main