Citron/Emulator

fix/audio-biquad-filter-v2-parameters #62

Closed

Zephyron wants to merge 8 commits from fix/audio-biquad-filter-v2-parameters into main

Zephyron commented

2025-12-04 09:49:37 +00:00

Owner

No description provided.

Zephyron added 8 commits

2025-12-04 09:49:37 +00:00

fix(audio): correct biquad filter ParameterVersion2 structure d211d56e47

- Change coefficients from fixed-point s16 to native float f32
- Reorder fields: enable, channel_count, then arrays
- Remove state field (not present in v2)
- Change inputs/outputs from std::array to C-style arrays

Signed-off-by: Zephyron <zephyron@citron-emu.org>

feat(audio): add ParameterVersion2 support to biquad filter commands e6a4f59bea

- Add v2 path in GenerateBiquadFilterCommand with float coefficients
- Add v2 path in GenerateCopyMixBufferCommand
- Add v2 path in GenerateBiquadFilterEffectCommand
- Use parameter-level enable field for v2
- Add buffer index validation for v2 commands

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(audio): improve biquad filter parameter validation d77b29ebfc

- Use IsChannelCountValid for consistent validation
- Validate buffer indices only for active channels
- Disable effects with corrupted parameters instead of sanitizing
- Improve error handling and logging for both v1 and v2

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(audio): add additional biquad filter validation checks 60d7af07de

- Add state pointer null checks in Process() and Verify()
- Add sample count validation
- Add buffer bounds checking with proper offset calculations
- Handle negative output indices with in-place processing fallback
- Improve error logging for debugging

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(audio): add bounds checking in EffectContext::UpdateStateByDspShared 3c0a3da873

- Calculate max_count to prevent out-of-bounds access
- Validate effect type before calling UpdateResultState
- Add try-catch for exception handling from corrupted effects
- Prevent crashes from invalid effect data

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(kernel): improve scheduler dispatch count handling 87facd330a

- Add defensive checks for disable_count in RescheduleCurrentCore
- Ensure disable_count is 1 before calling RescheduleCurrentCoreImpl
- Fix EnableDispatch() assertion failures
- Handle edge cases when disable_count is 0 or > 1

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(video): add null checks and fix BufferClear in Maxwell DMA 5818316de4

- Add null check for rasterizer before AccessAccelerateDMA
- Fix BufferClear to use component count correctly for 4-byte components
- Prevent crashes from null pointer dereferences

Signed-off-by: Zephyron <zephyron@citron-emu.org>

fix(network): auto-select first available interface when None is selected 4f20b90aaf

- Auto-select first available network interface if selected interface is \"None\" or empty
- Add logging when auto-selection occurs
- Prevent network issues when no interface is explicitly selected
- Use static flag to prevent repeated auto-selection

Signed-off-by: Zephyron <zephyron@citron-emu.org>

Zephyron closed this pull request

2025-12-05 04:52:46 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Citron/Emulator!62

No description provided.

Rows
Columns